JIT: Fix block morphing/physical promotion self-interference #85887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a couple of cases where it's possible that the decomposed stores will modify the address being used as part of the operation too early. In those cases we must spill the address to a new local ahead of time. Fix dotnet#85874
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsFix a couple of cases where it's possible that the decomposed stores Fix #85874
|
jakobbotsch
commented
May 7, 2023
| e1.Next = &e2; | ||
| e1.Value = 1234; | ||
| Consume(e1); | ||
| e1 = *e1.Next; |
There was a problem hiding this comment.
I'm surprised we haven't stumbled on this one before.
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS |
AndyAyersMS
approved these changes
May 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of cases where it's possible that the decomposed stores
will modify the address being used as part of the operation too early.
In those cases we must spill the address to a new local ahead of time.
Fix #85874