Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing changes in from ProducedBy enum change #82575

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Fix missing changes in from ProducedBy enum change #82575

merged 3 commits into from
Feb 24, 2023

Conversation

tlakollo
Copy link
Contributor

No description provided.

@tlakollo tlakollo added this to the 8.0.0 milestone Feb 24, 2023
@tlakollo tlakollo self-assigned this Feb 24, 2023
@ghost
Copy link

ghost commented Feb 24, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: tlakollo
Assignees: tlakollo
Labels:

area-NativeAOT-coreclr
Milestone: 8.0.0

MichalStrehovsky
MichalStrehovsky approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure the "CoreCLR Tools Unit Tests" CI legs gets triggered when src/tools/illink is touched to prevent this from happening again. Cc @dotnet/illink

@MichalStrehovsky
Copy link
Member

It builds now but looks like there are failing tests:

XUnit : error : Tests failed: /__w/1/s/artifacts/TestResults/Checked/Mono.Linker.Tests_net8.0_x64.html [net8.0|x64] [/__w/1/s/src/coreclr/tools/aot/Mono.Linker.Tests/Mono.Linker.Tests.csproj]
##[error]XUnit(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Tests failed: /__w/1/s/artifacts/TestResults/Checked/Mono.Linker.Tests_net8.0_x64.html [net8.0|x64]

@MichalStrehovsky MichalStrehovsky merged commit afacfaf into dotnet:main Feb 24, 2023
@tlakollo tlakollo deleted the FixProducedByErrors branch February 24, 2023 10:22
@MihaZupan MihaZupan mentioned this pull request Feb 24, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees

@tlakollo tlakollo

Labels
area-NativeAOT-coreclr
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tlakollo @MichalStrehovsky