Fix FnPtrTypeDesc::GetManagedClassObject #82325
Conversation
| @@ -349,8 +349,7 @@ bool TypeHandle::IsManagedClassObjectPinned() const | |||
| { | |||
| LIMITED_METHOD_DAC_CONTRACT; | |||
|
|
|||
| // Function pointers are always mapped to typeof(IntPtr) | |||
| return !GetLoaderAllocator()->CanUnload() || IsFnPtrType(); | |||
| return !GetLoaderAllocator()->CanUnload(); | |||
There was a problem hiding this comment.
Missed this -- prevents FPs from being moved during GC \ causing GC holes perhaps?
There was a problem hiding this comment.
The logic in this method has to be in sync with what GetManagedClassObject returns. If it is not in sync, it will lead to all sorts of problems.
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsThe code was missing support for allocating RuntimeType objects on frozen heap Fixes #82252
|
| } | ||
|
|
||
| GCPROTECT_END(); | ||
| if (m_hExposedClassObject == NULL) |
There was a problem hiding this comment.
I see that this pattern was recently changed to support frozen heaps, so this copy-paste above was stale.
The code was missing support for allocating RuntimeType objects on frozen heap Fixes dotnet#82252
…inters (dotnet#82321)" This reverts commit 473e278.
|
/azp run runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Ouch, thanks! It turns out to be a FOH-related issue indeed 😞 |
ghost
locked as resolved and limited conversation to collaborators
The code was missing support for allocating RuntimeType objects on frozen heap
Fixes #82252