Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Disable legacy interop measurements #81027

Merged
merged 1 commit into from
Jan 23, 2023
Merged

[wasm] Disable legacy interop measurements #81027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mono/sample/wasm/browser-bench/JSInterop.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ class JSInteropTask : BenchTask
public JSInteropTask()
{
measurements = new Measurement[] {
new LegacyExportIntMeasurement(),
// new LegacyExportIntMeasurement(),
new JSExportIntMeasurement(),
new LegacyExportStringMeasurement(),
// new LegacyExportStringMeasurement(),
new JSExportStringMeasurement(),
new JSImportIntMeasurement(),
new JSImportStringMeasurement(),
Expand Down
8 changes: 4 additions & 4 deletions src/mono/sample/wasm/browser-bench/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ class MainApp {
setTasks = exports.Sample.Test.SetTasks;
getFullJsonResults = exports.Sample.Test.GetFullJsonResults;

legacyExportTargetInt = BINDING.bind_static_method("[Wasm.Browser.Bench.Sample]Sample.ImportsExportsHelper:LegacyExportTargetInt");
jsExportTargetInt = exports.Sample.ImportsExportsHelper.JSExportTargetInt;
legacyExportTargetString = BINDING.bind_static_method("[Wasm.Browser.Bench.Sample]Sample.ImportsExportsHelper:LegacyExportTargetString");
jsExportTargetString = exports.Sample.ImportsExportsHelper.JSExportTargetString;
// legacyExportTargetInt = BINDING.bind_static_method("[Wasm.Browser.Bench.Sample]Sample.ImportsExportsHelper:LegacyExportTargetInt");
// jsExportTargetInt = exports.Sample.ImportsExportsHelper.JSExportTargetInt;
// legacyExportTargetString = BINDING.bind_static_method("[Wasm.Browser.Bench.Sample]Sample.ImportsExportsHelper:LegacyExportTargetString");
// jsExportTargetString = exports.Sample.ImportsExportsHelper.JSExportTargetString;

setModuleImports("main.js", {
Sample: {
Expand Down