New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#76881 internal properties in GetRuntimeProperties are not shown #77169

Merged

steveisok merged 12 commits into dotnet:main from mkhamoyan:76881_get_runtime_properties_fix

Nov 3, 2022

Contributor

mkhamoyan commented Oct 18, 2022 •

edited

Loading

Type.GetRuntimeProperties(), Type.GetProperties(..), etc. don't return internal properties that are defined in a base class of the given type when running on net6.0-android. When running the same code as a net6.0 console application or a Xamarin.Android app, the properties are correctly returned.


          dotnet#76881 internal properties in GetRuntimeProperties

583fd94

dotnet-issue-labeler bot commented Oct 18, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

ghost assigned mkhamoyan

Contributor Author

mkhamoyan commented Oct 18, 2022

/azp run runtime-extra-platforms

azure-pipelines bot commented Oct 18, 2022

Azure Pipelines successfully started running 1 pipeline(s).

runfoapp bot mentioned this pull request

Microsoft.Extensions.Hosting.Internal.HostTests.HostLifetimeOnStartedDelaysStart failed on rolling build #60121

Open


          Merge branch 'main' into 76881_get_runtime_properties_fix

ec34b43

Contributor Author

mkhamoyan commented Oct 19, 2022

/azp run runtime-extra-platforms

azure-pipelines bot commented Oct 19, 2022

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 19, 2022

Tracking issue for CI build timeouts #76454

Closed

Nuget restore error caused by 503s dotnet/arcade#11239

Closed

mkhamoyan added 3 commits

October 20, 2022 14:43


          dotnet#76881 remove excluding nonpublic props from base

777d521


          dotnet#76881 fix whitespace

8e0a12a


          dotnet#76881 fix whitespace

e7dcde9

Contributor Author

mkhamoyan commented Oct 20, 2022

/azp run runtime-extra-platforms

azure-pipelines bot commented Oct 20, 2022

Azure Pipelines successfully started running 1 pipeline(s).

mdh1418 reviewed

View reviewed changes

src/mono/mono/metadata/icall.c Show resolved Hide resolved


          Merge branch 'main' into 76881_get_runtime_properties_fix

71e98f7

Contributor Author

mkhamoyan commented Oct 23, 2022

/azp run runtime-extra-platforms

azure-pipelines bot commented Oct 23, 2022

Azure Pipelines successfully started running 1 pipeline(s).


          dotnet#76881 removed bflags & BFLAGS_NonPublic check

e5b800a

Contributor Author

mkhamoyan commented Oct 25, 2022

/azp run runtime-extra-platforms

azure-pipelines bot commented Oct 25, 2022

Azure Pipelines successfully started running 1 pipeline(s).

runfoapp bot mentioned this pull request

system.text.regularexpressions.tests work item #72834

Open

build-analysis bot mentioned this pull request

ComInterfaceGenerator.Unit.Tests.WorkItemExecution failing with Internal CLR error on Win x86 #77087

Closed

Contributor Author

mkhamoyan commented Oct 26, 2022

/azp run runtime-extra-platforms

azure-pipelines bot commented Oct 26, 2022

Azure Pipelines successfully started running 1 pipeline(s).


          dotnet#76881 check in initially TestIcuAppLocal passed

cf56625

Contributor Author

mkhamoyan commented Oct 26, 2022

/azp run runtime-extra-platforms

azure-pipelines bot commented Oct 26, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Contributor Author

mkhamoyan commented Nov 3, 2022

/azp run runtime-android

azure-pipelines bot commented Nov 3, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Contributor Author

mkhamoyan commented Nov 3, 2022

/azp run runtime-androidemulator

azure-pipelines bot commented Nov 3, 2022

Azure Pipelines successfully started running 1 pipeline(s).

mkhamoyan mentioned this pull request

System.Reflection.Tests.AssemblyTests.AssemblyGetForwardedTypesLoadFailure crashes on Android #77821

Open

vargaz approved these changes

View reviewed changes

thaystg approved these changes

View reviewed changes

steveisok approved these changes

View reviewed changes

steveisok merged commit a20b31a into dotnet:main

ghost locked as resolved and limited conversation to collaborators

Member

ivanpovazan commented Jun 5, 2023

@steveisok @mkhamoyan looking at the changes this PR introduced, it seems it also fixed: #86149 (and other duplicates)
Is this change going to be backported to net7 ?

Member

steveisok commented Jun 6, 2023

@ivanpovazan Yes, I think we should backport it.

Contributor Author

mkhamoyan commented Jun 6, 2023

/backport to release/7.0

github-actions bot unlocked this conversation

Contributor

github-actions bot commented Jun 6, 2023

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/5189519775

Contributor

github-actions bot commented Jun 6, 2023

@mkhamoyan an error occurred while backporting to release/7.0, please check the run log for details!

Error: @mkhamoyan is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=mkhamoyan

github-actions bot locked as resolved and limited conversation to collaborators

Member

ivanpovazan commented Jun 6, 2023

Thanks.
Let me doublecheck locally if it would fix the issue before backporting.

Member

ivanpovazan commented Jun 6, 2023

@mkhamoyan verified locally with release/7.0-staging branch that this change fixes #86149

should we backport it to release/7.0 or release/7.0-staging ?

Contributor Author

mkhamoyan commented Jun 6, 2023

@mkhamoyan verified locally with release/7.0-staging branch that this change fixes #86149

should we backport it to release/7.0 or release/7.0-staging ?

Thanks. release/7.0-staging should be.

Contributor Author

mkhamoyan commented Jun 6, 2023

/backport to release/7.0-staging

github-actions bot unlocked this conversation

Contributor

github-actions bot commented Jun 6, 2023

Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/5190285504

Contributor

github-actions bot commented Jun 6, 2023

@mkhamoyan an error occurred while backporting to release/7.0-staging, please check the run log for details!

Error: @mkhamoyan is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=mkhamoyan

github-actions bot locked as resolved and limited conversation to collaborators

Contributor Author

mkhamoyan commented Jun 6, 2023

/backport to release/7.0-staging

github-actions bot unlocked this conversation

Contributor

github-actions bot commented Jun 6, 2023

Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/5190331708

github-actions bot mentioned this pull request

[release/7.0-staging] #76881 internal properties in GetRuntimeProperties are not shown #87175

Merged

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

vargaz vargaz approved these changes

steveisok steveisok approved these changes

thaystg thaystg approved these changes

mdh1418 mdh1418 approved these changes

lambdageek Awaiting requested review from lambdageek

akoeplinger Awaiting requested review from akoeplinger

Labels

None yet