Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Support parameters of type Enum with icalls #73817

Merged
merged 7 commits into from
Aug 13, 2022
Merged

[wasm] Support parameters of type Enum with icalls #73817

merged 7 commits into from
Aug 13, 2022

Conversation

maraf
Copy link
Member

@maraf maraf commented Aug 11, 2022

Support for reading signatures for icalls with overloaded parameters containing enums.

Fixes #61277

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono labels Aug 11, 2022
@maraf maraf added this to the 7.0.0 milestone Aug 11, 2022
@maraf maraf requested a review from radical as a code owner August 11, 2022 21:19
@maraf maraf self-assigned this Aug 11, 2022
@maraf
Copy link
Member Author

maraf commented Aug 11, 2022

/azp run runtime-wasm

@ghost
Copy link

ghost commented Aug 11, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Support for reading signatures for icalls with overloaded parameters containing enums.

Fixes #61277

Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-Build-mono
Milestone: 7.0.0

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maraf
Make the paths less hardcoded.
6f80622 
Run the test only when IsUsingWorkloads=true.
Add comments about projects being build.
@maraf
Copy link
Member Author

maraf commented Aug 11, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maraf
Copy link
Member Author

maraf commented Aug 12, 2022 •
edited
Loading

@radical I guess that the packs path is not correct on linux/CI (it points to a sub directory of the project)

error MSB4062: The "ManagedToNativeGenerator" task could not be loaded from the assembly /datadisks/disk1/work/B31A0A2B/w/B96F09C5/e/snfgt5dd.gketasks/./dotnet-workload/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/7.0.0-ci/tasks/net7.0/WasmAppBuilder.dll. Could not load file or assembly '/datadisks/disk1/work/B31A0A2B/w/B96F09C5/e/snfgt5dd.gketasks/dotnet-workload/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/7.0.0-ci/tasks/net7.0/WasmAppBuilder.dll'. The system cannot find the file specified.
error MSB4062:  Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-73817-merge-807125bd1ba34ecbb8/Workloads-.PInvokeTableGeneratorTests/1/console.b273b450.log?helixlogtype=result

On Windows it passed

https://helix.dot.net/api/jobs/04cd9447-8876-4cb1-89c3-17c312670abd/workitems/Workloads-.PInvokeTableGeneratorTests?api-version=2019-06-17

@maraf
Copy link
Member Author

maraf commented Aug 12, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Aug 13, 2022

Libraries Test Run release coreclr Linux_musl x64 Debug failure is #73688 .

@radical radical merged commit 75228ac into dotnet:main Aug 13, 2022
@maraf maraf deleted the WasmIcallEnum branch August 13, 2022 15:40
@rzikm rzikm mentioned this pull request Aug 15, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical approved these changes

Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

[wasm] Parameters of type Enum not supported with icalls
2 participants
@maraf @radical