Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make things work for arrays of function pointers #71749

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

MichalStrehovsky
Copy link
Member

  • Don't try to obtain type handles for fields of types of function pointer arrays. We don't have type handles for function pointers right now.
  • Add function pointer support to name mangler. We still don't make EETypes for these, but debug info generation also needs mangled names. We currently generate debug info for function pointers as debug info for void*, but arrays of function pointers only partially go through that handling and still end up needing a mangled name for the function pointer.

Unblocks #71516.

Cc @steveharter @dotnet/ilc-contrib

* Don't try to obtain type handles for fields of types of function pointer arrays
* Add function pointer support to name mangler. We still don't make EETypes for these, but debug info generation also needs mangled names. We currently generate debug info for function pointers as debug info for `void*`, but arrays of function pointers only partially go through that handling and still end up needing a mangled name for the function pointer.
@MichalStrehovsky MichalStrehovsky merged commit 7331be5 into dotnet:main Jul 7, 2022
@MichalStrehovsky MichalStrehovsky deleted the unblockptr branch July 7, 2022 08:07
@ghost ghost locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants