Make DllImportGenerator emit a GeneratedCodeAttribute on our stubs #65868
Conversation
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsEmit a GeneratedCodeAttibute on our generated stubs for better auditing purposes. Fixes #64562
|
ghost
assigned 
| SeparatedList( | ||
| new[] | ||
| { | ||
| AttributeArgument(LiteralExpression(SyntaxKind.StringLiteralExpression, Literal("Microsoft.Interop.DllImportGenerator"))), |
There was a problem hiding this comment.
Since we're already using the DllImportGenerator assembly name to get the version string, we can probably just use it for the name too.
|
Do we also need to add the cc @marek-safar |
|
Yeah, I think we should add it to be trimmed. |
|
I've added the attribute to be trimmed and now I'm seeing really weird failures in Windows x86. Do we have any known Win-x86 issues at the moment? |
These should be fixed by #65910 . Merging from main should clear them. |
|
llvmfullaot timeouts are happening in other builds in main (such as https://dev.azure.com/dnceng/public/_build/results?buildId=1638498&view=results), so I'm going to merge this |
Emit a GeneratedCodeAttibute on our generated stubs for better auditing purposes. Fixes #64562