Clean up RegexCode opcodes and debug-only tracing #64346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsNo functional changes (other than deleting some useless debug-only tracing). Cleans up RegexCode's const int opcodes by moving them into a dedicated enum, and cleans up some unused debugging-related code. We may want to remove even more, but I at least wanted to get rid of RegexOptions.Debug so that we didn't have the extra option littered throughout the code.
|
joperezr
reviewed
Jan 26, 2022
src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexCode.cs
Show resolved
Hide resolved
joperezr
reviewed
Jan 26, 2022
...libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexNodeKind.cs
Outdated
Show resolved
Hide resolved
joperezr
approved these changes
Jan 26, 2022
danmoseley
reviewed
Jan 26, 2022
src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexOpcode.cs
Outdated
Show resolved
Hide resolved
danmoseley
reviewed
Jan 26, 2022
src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexOpcode.cs
Show resolved
Hide resolved
danmoseley
reviewed
Jan 26, 2022
src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexOpcode.cs
Show resolved
Hide resolved
No functional changes (other than deleting some useless debug-only tracing). Cleans up RegexCode's const int opcodes by moving them into a dedicated enum, and cleans up some unused debugging-related code. We may want to remove even more, but I at least wanted to get rid of RegexOptions.Debug so that we didn't have the extra option littered throughout the code.
stephentoub
force-pushed
the
cleanupregexcode
branch
from
04a3012 to
57d6baa
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes (other than deleting some useless debug-only tracing). Cleans up RegexCode's const int opcodes by moving them into a dedicated enum, and cleans up some unused debugging-related code. We may want to remove even more, but I at least wanted to get rid of RegexOptions.Debug so that we didn't have the extra option littered throughout the code.