-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attributes for required members #64287
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices Issue DetailsCloses #64248.
|
This also needs:
Also the ifdef for corelib is only necessary if we expect these files to be included into other assemblies beyond corelib. |
...s/System.Private.CoreLib/src/System/Diagnostics/CodeAnalysis/SetsRequiredMembersAttribute.cs
Outdated
Show resolved
Hide resolved
I somewhat expect that this attribute will be copied by customers, so I'd prefer to keep them. |
6dff2f2
to
94f6258
Compare
src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems
Outdated
Show resolved
Hide resolved
…b.Shared.projitems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/AttributesTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Closes #64248.
Relates to test plan dotnet/roslyn#57046