Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HostFactoryResolver - Increase default timeout to thirty seconds #61621

Merged
merged 8 commits into from
Nov 17, 2021
+53 −3
Merged

HostFactoryResolver - Increase default timeout to thirty seconds #61621

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b977b58
patch fix
maryamariyan Nov 15, 2021
7535772
improve messaging
maryamariyan Nov 15, 2021
5c4a8c9
Adds env var options for setting timeout
maryamariyan Nov 16, 2021
26d3bb8
Add test for timeout
maryamariyan Nov 16, 2021
aacc7e1
Update src/libraries/Microsoft.Extensions.HostFactoryResolver/src/Hos…
maryamariyan Nov 16, 2021
8aae991
PR feedback - increased the timeout length
maryamariyan Nov 16, 2021
8326cfa
Update src/libraries/Microsoft.Extensions.HostFactoryResolver/tests/H…
maryamariyan Nov 16, 2021
0b2f189
Update src/libraries/Microsoft.Extensions.HostFactoryResolver/tests/T…
maryamariyan Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Microsoft.Extensions.HostFactoryResolver/src/HostFactoryResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ internal sealed class HostFactoryResolver
public const string CreateHostBuilder = nameof(CreateHostBuilder);

// The amount of time we wait for the diagnostic source events to fire
private static readonly TimeSpan s_defaultWaitTimeout = Debugger.IsAttached ? Timeout.InfiniteTimeSpan : TimeSpan.FromSeconds(5);
private static readonly TimeSpan s_defaultWaitTimeout = Debugger.IsAttached ? Timeout.InfiniteTimeSpan : TimeSpan.FromMinutes(1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we improve the error message to make it clear that there was a timeout, are we worried that people will just kill the migration before seeing the error if we make this a full minute?

Copy link
Member Author

@maryamariyan maryamariyan Nov 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updates exception messaging and changed it to 30 seconds, assuming we would keep the environment variable option.


public static Func<string[], TWebHost>? ResolveWebHostFactory<TWebHost>(Assembly assembly)
{
Expand Down