Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HttpClient.PatchAsJsonAsync() apis #60672

Merged
merged 9 commits into from
Oct 25, 2021

Conversation

ikesnowy
Copy link
Contributor

Fixes #60531

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 20, 2021
@ghost
Copy link

ghost commented Oct 20, 2021

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #60531

Author: ikesnowy
Assignees: -
Labels:

area-System.Text.Json, new-api-needs-documentation, community-contribution

Milestone: -

@dnfadmin
Copy link

dnfadmin commented Oct 20, 2021

CLA assistant check
All CLA requirements met.

@eiriktsarpalis
Copy link
Member

@dotnet/ncl FYI

@eiriktsarpalis eiriktsarpalis added this to the 7.0.0 milestone Oct 20, 2021
@scalablecory
Copy link
Contributor

Were the revised defaults ran through API review? I think just an email will be enough...

Copy link
Contributor

@scalablecory scalablecory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once addressed

ikesnowy and others added 2 commits October 21, 2021 18:52
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eiriktsarpalis eiriktsarpalis self-assigned this Oct 21, 2021
@eiriktsarpalis eiriktsarpalis merged commit c1d6d84 into dotnet:main Oct 25, 2021
@ikesnowy ikesnowy deleted the issue-60531-patch-as-json-async branch October 26, 2021 02:17
@ghost ghost locked as resolved and limited conversation to collaborators Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Proposal]: HttpClient.PatchAsJsonAsync()
4 participants