Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][wasm] Add beginnings of support for WASI. #59752

Merged
merged 5 commits into from
Oct 8, 2021
Merged

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Sep 29, 2021

No description provided.

@ghost
Copy link

ghost commented Sep 29, 2021

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: vargaz
Assignees: -
Labels:

area-VM-meta-mono

Milestone: -

# FIXME: Is there a cmake option for this ?
set(DISABLE_SHARED_LIBS 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://cmake.org/cmake/help/latest/guide/tutorial/Selecting%20Static%20or%20Shared%20Libraries.html

Suggested change
# FIXME: Is there a cmake option for this ?
set(DISABLE_SHARED_LIBS 1)
option(BUILD_SHARED_LIBS "Disabling shared libraries for WASI" OFF)

@vargaz vargaz marked this pull request as draft September 30, 2021 04:26
@pavelsavara
Copy link
Member

Would it be different RID we could make it compatible with /p:TargetOS=Browser /p:TargetArchitecture=wasm ?

@vargaz
Copy link
Contributor Author

vargaz commented Sep 30, 2021

It's a very different environment, there is no JS, and currently, a lot of things are missing, like networking, threads etc.

@vargaz vargaz marked this pull request as ready for review September 30, 2021 16:37
@vargaz
Copy link
Contributor Author

vargaz commented Oct 1, 2021

With these changes, the build still fails because a lot of things are missing like pthread.h, socket functions, etc. But its a start.

@vargaz vargaz merged commit ce4eb48 into dotnet:main Oct 8, 2021
@vargaz vargaz deleted the wasi1 branch October 8, 2021 21:08
@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants