Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change compile time dependency of ICU API ucol_setMaxVariable to be runtime instead. #58485

Merged
merged 2 commits into from
Sep 2, 2021

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Sep 1, 2021

During building the runtime, we have a compile-time check to decide to link against the ICU API ucol_setVariableTop or ucol_setMaxVariable according to the ICU version installed on the build machine. That causes problems as we may compile against a higher version of ICU, and we run against a lower version of ICU which causes an error like

dotnet --version

Cannot get symbol ucol_setMaxVariable_50 from libicui18n
Error: /lib64/libicui18n.so.50: undefined symbol: ucol_setMaxVariable_50

And cannot run dotnet or any .NET app on Linux. #57983 is example of the reported issue for that problem.

This change is getting rid of the compile-time check and making it a runtime check instead.

@ghost
Copy link

ghost commented Sep 1, 2021

Tagging subscribers to this area: @tarekgh, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

During building the runtime, we have a compile-time check to decide to link against the ICU API ucol_setVariableTop or ucol_setMaxVariable according to the ICU version installed on the build machine. That causes problems as we may compile against a higher version of ICU, and we run against a lower version of ICU which causes an error like

dotnet --version

Cannot get symbol ucol_setMaxVariable_50 from libicui18n
Error: /lib64/libicui18n.so.50: undefined symbol: ucol_setMaxVariable_50

And cannot run dotnet or any .NET app on Linux. #57983 is example of the reported issue for that problem.

This change is getting rid of the compile-time check and making it a runtime check instead.

Author: tarekgh
Assignees: -
Labels:

area-System.Globalization

Milestone: -

@tarekgh
Copy link
Member Author

tarekgh commented Sep 1, 2021

CC @janvorli

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@tarekgh tarekgh merged commit af4bb8b into dotnet:main Sep 2, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants