Run processenvironment EventPipe test as a separate process. #51022
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @tommcdon Issue DetailsDue to the following issue: https://github.com/dotnet/runtime/tree/main/src/tests/tracing/eventpipe/processenvironment test fails on Mono runtime on none Windows platforms. Since this test tests diagnostics server process environment command and not the implementation of SetEnvironmentVariable, running the diagnostics server as a separate process and pass over the environments variable to validate as part of running process would be more inline with how this will be used and mitigate the Mono runtime issue.
|
|
Yes, we will probably get Mono over to same behaviour as CoreClr, but since this test is failing due to this (and guess it was not the intent for this test to validate this in the first place), doing this change will unblock the EventPipe test on none Windows Mono runtime, independently of fixing the underlying issue. |
lateralusX
changed the title
ghost
locked as resolved and limited conversation to collaborators
Due to the following issue:
#51019
https://github.com/dotnet/runtime/tree/main/src/tests/tracing/eventpipe/processenvironment test fails on Mono runtime on none Windows platforms.
Since this test tests diagnostics server process environment command and not the implementation of SetEnvironmentVariable, running the diagnostics server as a separate process and pass over the environments variable to validate as part of running process would be more inline with how this will be used and mitigate the Mono runtime issue.