Cleanup PlatformSpecific/SkipOnMono attributes that skip a platform

[akoeplinger]

We have a bunch of test assemblies that don't make sense on some platforms, e.g. Browser.
Right now we're skipping them via [SkipOnMono("reason", TestPlatforms.Browser)] but there's nothing that inherently ties this to Mono other than the current implementation.

The more generic SkipOnPlatform attribute can be used instead.
We can also use it in places where we do [PlatformSpecific(~TestPlatforms....)] to avoid the double inversion.

[ghost]

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

We have a bunch of test assemblies that don't make sense on some platforms, e.g. Browser.
Right now we're skipping them via [SkipOnMono("reason", TestPlatforms.Browser)] but there's nothing that inherently ties this to Mono other than the current implementation.

Using the more generic SkipOnPlatform attribute can be used instead.
We can also use it in places where we do [PlatformSpecific(~TestPlatforms....)] to avoid the double inversion.

Author:	akoeplinger
Assignees:	-
Labels:	area-Infrastructure-libraries
Milestone:	-

[safern]

Thanks for adding the docs 🎉

[safern]

Should we also update eng/Version.Details.xml so that darc knows which version we depend on?

What about assemblies using IgnoreForCi?

[akoeplinger]

Should we also update eng/Version.Details.xml so that darc knows which version we depend on?

#50901 was just merged so I can take that out again now.

What about assemblies using IgnoreForCi?

What about them? The <IgnoreForCI> property is used so we don't send tests to helix that will end up executing 0 tests which is wasting resources, it's kinda orthogonal except that if we have an assembly-level SkipOnPlatform then we should have a corresponding IgnoreForCI on that platform in the csproj.

[safern]

What about them? The property is used so we don't send tests to helix that will end up executing 0 tests which is wasting resources, it's kinda orthogonal except that if we have an assembly-level SkipOnPlatform then we should have a corresponding IgnoreForCI on that platform in the csproj.

Right, but what I meant was, do we have any IgnoreForCI that we should add an attribute to the assembly so that locally they don't run?

[akoeplinger]

@safern thanks, I see what you mean now. I checked and we don't have any cases like that, but I found a few of the reverse case where we'd have [assembly: SkipOnPlatform()] but no IgnoreForCI in the csproj.

[safern]

Do we have any docs

EDIT: I accidentally included this comment 😄

[ViktorHofer]

This looks great. Thank you