Use EVP_PKEY for RSA public key operations #50668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change the storage model to SafeEvpPKeyHandle, only import and export use legacy SafeRsaHandle.
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsThis also changes the primary storage model for RSAOpenSsl to be a SafeEvpPKeyHandle, Contributes to #46526.
|
krwq
reviewed
Apr 19, 2021
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Rsa.cs
Show resolved
Hide resolved
krwq
reviewed
Apr 19, 2021
...libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.EvpPkey.Rsa.cs
Show resolved
Hide resolved
krwq
reviewed
Apr 19, 2021
krwq
reviewed
Apr 19, 2021
krwq
approved these changes
Apr 20, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the primary storage model for RSAOpenSsl to be a SafeEvpPKeyHandle,
instead of the legacy SafeRsaHandle. SafeRsaHandle is still used for import, export, and the
IntPtr-based ctor in the public RSAOpenSsl class.Contributes to #46526.