Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ConfigurationKeyNameAttribute to binder and updated tests. #50338

Merged
merged 16 commits into from
Apr 12, 2021
Merged

Add ConfigurationKeyNameAttribute to binder and updated tests. #50338

merged 16 commits into from
Apr 12, 2021

Conversation

Coderrob
Copy link
Contributor

@Coderrob Coderrob commented Mar 28, 2021 •
edited
Loading

API implementation of #36010

  • Add ConfigurationKeyName attribute to the Configuration Binder project
  • Update Configuration Binder to use key name from the new attribute in binding property values
  • Add test using ConfigurationKeyName attribute to map the configuration dictionary key

@ghost
Copy link

ghost commented Mar 28, 2021

Tagging subscribers to this area: @maryamariyan, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

API implementation of #36010

  • Add ConfigurationKeyNameAttribute to the Configuration Binder project
  • Update Configuration Binder to use key name from the new attribute in binding property values
  • Add test using new attribute to map DataMember[] to the configuration dictionary key
Author: Coderrob
Assignees: -
Labels:

area-Extensions-Configuration
Milestone: -

@davidfowl
Copy link
Member

cc @HaoK

@davidfowl
Copy link
Member

CreateDefaultBuilder_SecretsDoesReload failed.

cc @maryamariyan

@maryamariyan
Copy link
Member

CreateDefaultBuilder_SecretsDoesReload failed.

issue logged #48696

@HaoK
Copy link
Member

HaoK commented Mar 31, 2021

Unrelated to this PR, but config reload tests were among the flakiest of tests for us back in the day as well, the change notifications were never super reliable

@maryamariyan
Copy link
Member

maryamariyan commented Mar 31, 2021 •
edited
Loading

Unrelated to this PR, but config reload tests were among the flakiest of tests for us back in the day as well, the change notifications were never super reliable

Thanks @HaoK I think that's relevant to the issue reported in #48696. I'll check to see how similar tests in configuration relying on change notification look like, in order to fixup that test

@Coderrob Coderrob requested review from HaoK and maryamariyan March 31, 2021 04:36
@Coderrob
Copy link
Contributor Author

@safern @HaoK what are your opinions on providing a default value to the GetPropertyValue function? Yay or nay?

Previous behavior returned null or threw exception. Just nipped adding the default value to go back to how it was.

@HaoK
Copy link
Member

HaoK commented Mar 31, 2021

Previous behavior returned null or threw exception. Just nipped adding the default value to go back to how it was.

I would leave the existing behavior alone

@Coderrob Coderrob requested a review from HaoK April 1, 2021 00:41
@Coderrob Coderrob requested a review from safern April 1, 2021 00:41
@Coderrob Coderrob requested a review from safern April 5, 2021 22:47
@Coderrob Coderrob requested a review from safern April 9, 2021 05:11
@Coderrob Coderrob requested a review from safern April 11, 2021 22:27
@Coderrob
Copy link
Contributor Author

@safern the CreateDefaultBuilder_SecretsDoesReload error struck again. Do you have an easier way to tickle a new build?

@runfoapp runfoapp bot mentioned this pull request Apr 12, 2021
Closed
safern
safern approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@safern safern left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the good work here, @Coderrob!

@safern safern merged commit 4936902 into dotnet:main Apr 12, 2021
@Coderrob Coderrob deleted the config-key-name branch April 13, 2021 01:04
@Coderrob
Copy link
Contributor Author

Coderrob commented Apr 13, 2021 •
edited
Loading

LGTM, thanks for the good work here, @Coderrob!

@safern Thank you for the help! Thank you to all involved in reviewing and approving the changes.

@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern approved these changes

@maryamariyan maryamariyan Awaiting requested review from maryamariyan

@HaoK HaoK Awaiting requested review from HaoK

Assignees
No one assigned
Labels
area-Extensions-Configuration
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Coderrob @davidfowl @maryamariyan @HaoK @safern @karelz