Fix Socket.SendFile test: SliceBuffers_Success #48457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #47734. I made a mistake in #47479 by expecting to get all the sent data in a single receive in the new The test now uses the same checksum logic as other SendFile tests. /cc @geoffkizer
|
stephentoub
reviewed
Feb 19, 2021
src/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 19, 2021
src/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Feb 19, 2021
stephentoub
approved these changes
Feb 19, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47734.
I made a mistake in #47479 by expecting to get all the sent data in a single receive in the new
SliceBuffers_Successtest. Interestingly this is how it actually happens on a loopback device everywhere except MacOS, where the underlying separate sending of the pre and post buffers may result in separate subsequent receives sometimes.The test now uses the same checksum logic as other SendFile tests.
/cc @geoffkizer