Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Enable CoreClr runtime tests on Mono Windows x64. #47526

Closed
wants to merge 6 commits into from
Closed

WIP: Enable CoreClr runtime tests on Mono Windows x64. #47526

wants to merge 6 commits into from

Conversation

lateralusX
Copy link
Member

No description provided.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@monojenkins monojenkins mentioned this pull request Jan 27, 2021
Closed
@runfoapp runfoapp bot mentioned this pull request Jan 27, 2021
Closed
@steveisok steveisok self-requested a review January 27, 2021 21:32
This was referenced Jan 27, 2021
Open
Open
Closed
Closed
@lateralusX lateralusX force-pushed the lateralusX/enable-runtime-tests-windows branch from b769e47 to d6d4621 Compare February 1, 2021 10:00
@lateralusX lateralusX force-pushed the lateralusX/enable-runtime-tests-windows branch from d6d4621 to 02228a5 Compare February 1, 2021 10:07
@lateralusX
Copy link
Member Author

Many of the failures in Runtime Windows x64 release is due to issue addressed in #47705.

@lateralusX
Copy link
Member Author

Taking fix from #47705 on a test drive.

@runfoapp runfoapp bot mentioned this pull request Feb 2, 2021
Closed
@lateralusX
Copy link
Member Author

Test run now includes tests that are failing on Mono Windows x64 and needs to be addressed before lane can be turned on. Some seems to be failing due to missing COM support on netcore Mono, so probably needs to be turned of for Mono (not run on Unix platforms anyways, so could be excluded on Mono platform) and some seems to be around specific JIT constructions (potentially specific Windows tests). Since it will take some time to walk through an analyse failures it will probably need more formal prio and scheduling, but this PR will then be a good candidate to continue that work.

Base automatically changed from master to main March 1, 2021 09:07
@ghost ghost closed this Mar 31, 2021
@ghost
Copy link

ghost commented Mar 31, 2021

Draft Pull Request was automatically closed for inactivity. It can be manually reopened in the next 30 days if the work resumes.

@lateralusX lateralusX reopened this Mar 31, 2021
@ghost ghost closed this Apr 30, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

Draft Pull Request was automatically closed for inactivity. Please let us know if you'd like to reopen it.

@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveisok steveisok Awaiting requested review from steveisok steveisok is a code owner

@thaystg thaystg Awaiting requested review from thaystg thaystg will be requested when the pull request is marked ready for review thaystg is a code owner

@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas will be requested when the pull request is marked ready for review vitek-karas is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
area-Build-mono
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lateralusX @karelz