Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stops logging MSBuild errors when AOT compiler writes to stderr #47057

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

steveisok
Copy link
Member

The MonoAotCompiler task will just write to the MSBuild log as info rather than error. Prevents AOT compilation from failing when no real failure occurred

The MonoAotCompiler task will just write to the MSBuild log as info rather than error.  Prevents AOT compilation from failing when no real failure occurred
@steveisok steveisok requested a review from akoeplinger January 15, 2021 20:57
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Jan 15, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

The MonoAotCompiler task will just write to the MSBuild log as info rather than error. Prevents AOT compilation from failing when no real failure occurred

Author: steveisok
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@steveisok steveisok merged commit f765507 into dotnet:master Jan 19, 2021
@steveisok steveisok deleted the ios-info-stderr branch January 19, 2021 21:12
@ghost ghost locked as resolved and limited conversation to collaborators Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants