Fix Mono Windows x64 SIMD support. #46812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lateralusX
force-pushed
the
lateralusX/fix-windows-x64-simd
branch
from
30e4352 to
ff25d68
Compare
lateralusX
requested review from
CoffeeFlux,
lambdageek,
marek-safar,
SamMonoRT and
vargaz
as code owners
vargaz
approved these changes
Jan 12, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mono Windows x64 SIMD support was not fully implemented on netcore causing issues reported in #1933. PR integrate logic from Mono Windows x64 SIMD implementation into Mono netcore SIMD implementation needed to correctly handle Windows x64 value type ABI together with SIMD intrinsics.
PR also re-enables SIMD optimization on Windows x64.