Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0] Add workarounds for brew on old OSX images #45809

Merged
merged 4 commits into from
Dec 9, 2020

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 9, 2020

Backport of #45802 to release/5.0

/cc @safern

Customer Impact

Testing

Risk

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@safern
Copy link
Member

safern commented Dec 9, 2020

@danmosemsft @Anipik this is an infra only change to fix the OSX builds.

@ViktorHofer
Copy link
Member

@Anipik can merge this or do we need to couple it with the branding changes PR?

@safern
Copy link
Member

safern commented Dec 9, 2020

@mmitche can we merge this without the branding changes?

@mmitche
Copy link
Member

mmitche commented Dec 9, 2020

@mmitche can we merge this without the branding changes?

Yes, i believe there was already one pre-branding change so things will need to be checked anyway.

@safern
Copy link
Member

safern commented Dec 9, 2020

Steps that exercise this are ahead. Merging to unblock other PRs/builds.

@safern safern merged commit e5587e5 into release/5.0 Dec 9, 2020
@safern safern deleted the backport/pr-45802-to-release/5.0 branch December 9, 2020 20:31
@ghost ghost locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants