-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize SendReceive tests and isolate non-parallel test collection #44591
Organize SendReceive tests and isolate non-parallel test collection #44591
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue meta data
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/libraries/System.Net.Sockets/tests/FunctionalTests/SendReceive/SendReceiveCommon.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Sockets/tests/FunctionalTests/SendReceive/SendReceiveListener.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, but I think we should change a couple class/file names... see above.
This comment has been minimized.
This comment has been minimized.
@geoffkizer all addressed. |
This comment has been minimized.
This comment has been minimized.
The OuterLoop test failures are unrelated (System.Xml, Http and #44015). |
Some
SendReceive
socket tests may be prone to timing issues on CI. This seems to be the root cause of #1712. We need a reliable way to run such tests to unblock the work on new UDP socket API-s in #33418.This PR defines a new
SendReceiveNonParallel
test group, movingSendToRecvFrom_Datagram_UDP
into that group. Since this is already a significant reorganization, it seemed reasonable to also:SendReceive_[SubVariant]
or
SendReceiveNonParallel_[SubVariant]
SendReceive.cs
into multiple files:SendReceive.cs
for the parallel variantsSendReceiveNonParallel.cs
for the new, non-parallel variantsSendReceive
toSendReceiveCommon
(to avoid name collision and confusion withSendReceive<T>
) and move it toSendReceiveCommon.cs
SendReceiveListener
andSendReceiveUdpClient
to separate filesFixes #1712
/cc @geoffkizer