Make NLS default globalization mode

[safern]

This is to test what happens with upstack repos and to move early before the decision is made. If we don't want this we can always revert this change.

cc: @danmosemsft @mmitche @SteveCarrollMSFT

[danmoseley]

Seems to make sense to me.

[ghost]

Tagging subscribers to this area: @tarekgh, @safern, @krwq
See info in area-owners.md if you want to be subscribed.

[GrabYourPitchforks]

LGTM, some questions and a request that we change the target URL.

[safern]

Note: this also changes Mono Desktop default. I guess it makes sense to be consistent.

cc: @marek-safar @steveisok

[GrabYourPitchforks]

Failing test System.Numerics.Vectors.Tests is known issue #41108.

[safern]

So I just doubled checked that the script to change the test mode works... this is a test run in Windows8

icu was not found, so running the tests using NLS.
Updating nls switch in System.Globalization.Icu.Tests.runtimeconfig.json to true...
----- start Thu 10/29/2020  5:05:14.56 ===============  To repro directly: ===================================================== 
pushd C:\h\w\B9870A42\w\B04E0993\e\
"C:\h\w\B9870A42\p\dotnet.exe" exec --runtimeconfig System.Globalization.Icu.Tests.runtimeconfig.json --depsfile System.Globalization.Icu.Tests.deps.json xunit.console.dll System.Globalization.Icu.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing 
popd
===========================================================================================================

C:\h\w\B9870A42\w\B04E0993\e>"C:\h\w\B9870A42\p\dotnet.exe" exec --runtimeconfig System.Globalization.Icu.Tests.runtimeconfig.json --depsfile System.Globalization.Icu.Tests.deps.json xunit.console.dll System.Globalization.Icu.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing  
  Discovering: System.Globalization.Icu.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Globalization.Icu.Tests (found 435 of 439 test cases)
  Starting:    System.Globalization.Icu.Tests (parallel test collections = on, max threads = 2)
    System.Globalization.Tests.GetCultureInfoTests.GetCultureInfo [SKIP]
      Condition(s) not met: "PlatformSupportsFakeCulture"
    System.Globalization.Tests.GetCultureInfoTests.TestGetCultureInfoWithNoneConstructedCultures [SKIP]
      Condition(s) not met: "PlatformSupportsFakeCulture"
    System.Globalization.Tests.GetCultureInfoTests.TestFakeCultureNames [SKIP]
      Condition(s) not met: "PlatformSupportsFakeCulture"
    System.Globalization.Tests.GetCultureInfoTests.TestInvalidCultureNames [SKIP]
      Condition(s) not met: "PlatformSupportsFakeCulture"
    System.Globalization.Tests.NumberFormatInfoPercentPositivePattern.PercentPositivePattern_Get_ReturnsExpected_ICU [SKIP]
      Condition(s) not met: "IsIcuGlobalization"
    System.Globalization.Tests.DateTimeFormatInfoLongTimePattern.LongTimePattern_CheckReadingTimeFormatWithSingleQuotes_ICU [SKIP]
      Condition(s) not met: "IsIcuGlobalization"
 System.Globalization.Tests.NumberFormatInfoPercentNegativePattern.PercentNegativePattern_Get_ReturnsExpected_ICU [SKIP]
      Condition(s) not met: "IsIcuGlobalization"

That shows at the top that it didn't find ICU and as you can see it didn't meet the IsIcuGlobalization condition in some of the tests there.

Then this is the output of a Windows 19H1 test run which ICU is supported:

ICU exists in system, running tests with ICU.
----- start Thu 10/29/2020  5:15:41.18 ===============  To repro directly: ===================================================== 
pushd C:\h\w\AF3409E2\w\A34B0915\e\
"C:\h\w\AF3409E2\p\dotnet.exe" exec --runtimeconfig System.Globalization.Icu.Tests.runtimeconfig.json --depsfile System.Globalization.Icu.Tests.deps.json xunit.console.dll System.Globalization.Icu.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing 
popd
===========================================================================================================

C:\h\w\AF3409E2\w\A34B0915\e>"C:\h\w\AF3409E2\p\dotnet.exe" exec --runtimeconfig System.Globalization.Icu.Tests.runtimeconfig.json --depsfile System.Globalization.Icu.Tests.deps.json xunit.console.dll System.Globalization.Icu.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing  
  Discovering: System.Globalization.Icu.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Globalization.Icu.Tests (found 435 of 439 test cases)
  Starting:    System.Globalization.Icu.Tests (parallel test collections = on, max threads = 2)
    System.Globalization.Tests.CultureInfoAll.TestAllCultures_Nls [SKIP]
      Condition(s) not met: "IsNlsGlobalization"
  Finished:    System.Globalization.Icu.Tests
=== TEST EXECUTION SUMMARY ===
   System.Globalization.Icu.Tests  Total: 1857, Errors: 0, Failed: 0, Skipped: 1, Time: 20.473s

You can see ICU exists in system, running tests with ICU. at the top and also, Condition(s) not met: "IsNlsGlobalization".

[danmoseley]

Thanks for checking

[safern]

Just an idea came to mind: Should we check for false instead when defaultValue == true?

[danmoseley]

I wouldn't reset things for that.

[mmitche]

@safern Good to merge as soon as you're reasonably comfortable with it.

[danmoseley]

Note for anyone coming across this PR: this does not mean there is a plan change: we are just gathering more data to inform a decision.