Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/5.0] Port Add Designer attributes to types that had it in full framework #41066

Merged
merged 1 commit into from
Aug 20, 2020
Merged

[release/5.0] Port Add Designer attributes to types that had it in full framework #41066

merged 1 commit into from
Aug 20, 2020

Conversation

safern
Copy link
Member

@safern safern commented Aug 19, 2020 •
edited
Loading

Master PR: #40966

cc: @RussKie @danmosemsft @ericstj

@safern
Add Designer attributes to types that had it in full framework (part …
28b4675 
…2) (dotnet#40966)

* Move DesignerSerializerAttribute to S.CM.Primitives and add to StringDictionary

* Add TolboxItemAttribute to types that had it in Desktop

* Remove TypeDescriptionProviderAttribute from DefaultGenApiDocIds

* PR Feedback, fix build
@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@safern safern changed the title Port [release/5.0] Port Add Designer attributes to types that had it in full framework Aug 19, 2020
@safern
Copy link
Member Author

safern commented Aug 19, 2020

Description

The winforms designer depends on these attributes to be added to types in order to display the information correctly on the designer.

Customer Impact

Properties and metadata will not be displayed correctly where as in Full Framework it does.

Regression?

From Full Framework, when we ported the types.

Risk

low. This only adds attributes and moves DesignerSerializerAttribute from System.ComponentModel.TypeConverters to System.ComponentModel.Primitives.

Test changes in this PR

Tests for the attributes are still running.

@danmoseley
Copy link
Member

danmoseley commented Aug 19, 2020 •
edited
Loading

approved. winforms request, Winforms designer experience is important scenario for 5.0, localized change.

@safern safern requested a review from ericstj August 20, 2020 18:26
@danmoseley
Copy link
Member

failures were #41108

@danmoseley danmoseley merged commit 7e5a11a into dotnet:release/5.0 Aug 20, 2020
@safern safern deleted the PortDesignerAttributesFx branch August 20, 2020 19:08
@safern safern mentioned this pull request Aug 24, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericstj ericstj ericstj approved these changes

Assignees
No one assigned
Labels
area-Meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@safern @Dotnet-GitSync-Bot @danmoseley @ericstj