Fix cross OS DAC regression #31901
Merged
Fix cross OS DAC regression #31901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix DAC cross OS compilations regressions introduced by dotnet#31659
sdmaclea
force-pushed
the
DacRegression
branch
from
6eb901b to
2b3b6c0
Compare
hoyosjs
approved these changes
Feb 7, 2020
|
|
||
| target_link_libraries(mscordaccore PRIVATE ${COREDAC_LIBRARIES}) | ||
|
|
||
| # add the install targets | ||
| install_clr(TARGETS mscordaccore) | ||
| install_clr(TARGETS mscordaccore DESTINATION sharedFramework SKIP_STRIP) | ||
|
|
||
| if(CLR_CMAKE_TARGET_WIN32) |
There was a problem hiding this comment.
Are we gonna produce long name cross-OS dac too?
There was a problem hiding this comment.
I didn't find/notice that code....
There is probably a whole round of things to do for CI, official builds, testing. So far I have been focusing on making it compile.
There was a problem hiding this comment.
I guess this is the code. There is longer path name that is built. It ends in a Linux.<Target_Arch>.<BuildType> directory with a typical windows dac name.
ghost
added
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression in cross OS DAC compilation.
Also reduces set of binaries which need to compile during cross OS DAC compilation