Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null IV for Create{Encryptor,Decryptor}. #31634

Merged
merged 1 commit into from
Feb 4, 2020
+4 −4
Merged

Allow null IV for Create{Encryptor,Decryptor}. #31634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...es/System.Security.Cryptography.Primitives/ref/System.Security.Cryptography.Primitives.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,9 +231,9 @@ public void Clear() { }
public static System.Security.Cryptography.SymmetricAlgorithm Create() { throw null; }
public static System.Security.Cryptography.SymmetricAlgorithm? Create(string algName) { throw null; }
public virtual System.Security.Cryptography.ICryptoTransform CreateDecryptor() { throw null; }
public abstract System.Security.Cryptography.ICryptoTransform CreateDecryptor(byte[] rgbKey, byte[] rgbIV);
public abstract System.Security.Cryptography.ICryptoTransform CreateDecryptor(byte[] rgbKey, byte[]? rgbIV);
public virtual System.Security.Cryptography.ICryptoTransform CreateEncryptor() { throw null; }
public abstract System.Security.Cryptography.ICryptoTransform CreateEncryptor(byte[] rgbKey, byte[] rgbIV);
public abstract System.Security.Cryptography.ICryptoTransform CreateEncryptor(byte[] rgbKey, byte[]? rgbIV);
public void Dispose() { }
protected virtual void Dispose(bool disposing) { }
public abstract void GenerateIV();
Expand Down
4 changes: 2 additions & 2 deletions ...m.Security.Cryptography.Primitives/src/System/Security/Cryptography/SymmetricAlgorithm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,14 +173,14 @@ public virtual ICryptoTransform CreateDecryptor()
return CreateDecryptor(Key, IV);
}

public abstract ICryptoTransform CreateDecryptor(byte[] rgbKey, byte[] rgbIV);
public abstract ICryptoTransform CreateDecryptor(byte[] rgbKey, byte[]? rgbIV);

public virtual ICryptoTransform CreateEncryptor()
{
return CreateEncryptor(Key, IV);
}

public abstract ICryptoTransform CreateEncryptor(byte[] rgbKey, byte[] rgbIV);
public abstract ICryptoTransform CreateEncryptor(byte[] rgbKey, byte[]? rgbIV);

public void Dispose()
{
Expand Down