[android] Make Android app on coreclr use host-runtime contract and provide external assembly probe #112938
Conversation
|
Tagging subscribers to this area: @akoeplinger, @matouskozak |
elinor-fung
force-pushed
the
androidSample-useProbe
branch
from
bb494f9 to
00cddbb
Compare
elinor-fung
changed the title
AndroidSampleApp use host-runtime contract and provide external assembly probe
elinor-fung
force-pushed
the
androidSample-useProbe
branch
from
00cddbb to
1ea37be
Compare
Co-authored-by: kasperk81 <83082615+kasperk81@users.noreply.github.com>
| appctx_keys[0] = "RUNTIME_IDENTIFIER"; | ||
| appctx_keys[1] = "APP_CONTEXT_BASE_DIRECTORY"; | ||
| appctx_keys[2] = "TRUSTED_PLATFORM_ASSEMBLIES"; | ||
| appctx_keys[2] = "HOST_RUNTIME_CONTRACT"; |
There was a problem hiding this comment.
This makes the Android app on coreclr always go through the external assembly probe, which is more like the real scenario. Is there usefulness in keeping the TPA property / runtime loading from disk and letting that be enabled via some define that can be specified when building the app?
There was a problem hiding this comment.
I don't think so. We only loaded from disk before because it was the easiest path.
There was a problem hiding this comment.
I agree with Steve, although it would be interesting to see the difference in performance.
| appctx_keys[0] = "RUNTIME_IDENTIFIER"; | ||
| appctx_keys[1] = "APP_CONTEXT_BASE_DIRECTORY"; | ||
| appctx_keys[2] = "TRUSTED_PLATFORM_ASSEMBLIES"; | ||
| appctx_keys[2] = "HOST_RUNTIME_CONTRACT"; |
There was a problem hiding this comment.
I agree with Steve, although it would be interesting to see the difference in performance.
|
/azp run runtime-androidemulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-androidemulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
host_runtime_contract::external_assembly_probe