Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make counting of IO completion work items more precise on Windows #112793

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

kouvel
Copy link
Member

@kouvel kouvel commented Feb 21, 2025

- Follow-up to dotnet#106854. Issue: dotnet#104284.
- Before the change, the modified test case often yields 5 or 6 completed work items, due to queue-processing work items that happen to not process any user work items. After the change, it always yields 4.
- Looks like it doesn't hurt to have more-precise counting, and there was a request to backport a fix to .NET 8, where it's more necessary to fix the issue
@kouvel kouvel added this to the 10.0.0 milestone Feb 21, 2025
@kouvel kouvel self-assigned this Feb 21, 2025
@Copilot Copilot bot review requested due to automatic review settings February 21, 2025 18:02
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs:1492

  • Ensure that the test case covers scenarios where 'allWorkItemsCompleted.CheckedWait()' might timeout or fail.
allWorkItemsCompleted.CheckedWait();
Copy link
Member

@eduardo-vp eduardo-vp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants