Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CPU utilization checks in the thread pool configurable #112789

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

kouvel
Copy link
Member

@kouvel kouvel commented Feb 21, 2025

  • On Windows, checking CPU utilization seems to involve a small amount of overhead, which can become noticeable or even significant in some scenarios. This change makes the intervals of time over which CPU utilization is computed configurable. Increasing the interval increases the period at which CPU utilization is updated. The same config var can also be used to disable CPU utilization checks and have features that use it behave as though CPU utilization is low.
  • CPU utilization is used by the starvation heuristic and hill climbing. When CPU utilization is very high, the starvation heuristic reduces the rate of thread injection in starved cases. When CPU utilization is high, hill climbing avoids settling on higher thread count control values.
  • CPU utilization is currently updated when the gate thread performs periodic activities, which happens typically every 500 ms when a worker thread is active. There is one gate thread per .NET process.
  • In scenarios where there are many .NET processes running, and where many of them frequently but lightly use the thread pool, overall CPU usage may be relatively low, but the overhead from CPU utilization checks can bubble up to a noticeable portion of overall CPU usage. In a scenario involving 100s of .NET processes, it was seen that CPU utilization checks amount to 0.5-1% of overall CPU usage on the machine, which was considered significant.

- On Windows, checking CPU utilization seems to involve a small amount of overhead, which can become noticeable or even significant in some scenarios. This change makes the intervals of time over which CPU utilization is computed configurable. Increasing the interval increases the period at which CPU utilization is updated. The same config var can also be used to disable CPU utilization checks and have features that use it behave as though CPU utilization is low.
- CPU utilization is used by the starvation heuristic and hill climbing. When CPU utilization is very high, the starvation heuristic reduces the rate of thread injection in starved cases. When CPU utilization is high, hill climbing avoids settling on higher thread count control values.
- CPU utilization is currently updated when the gate thread performs periodic activities, which happens typically every 500 ms when a worker thread is active. There is one gate thread per .NET process.
- In scenarios where there are many .NET processes running, and where many of them frequently but lightly use the thread pool, overall CPU usage may be relatively low, but the overhead from CPU utilization checks can bubble up to a noticeable portion of overall CPU usage. In a scenario involving 100s of .NET processes, it was seen that CPU utilization checks amount to 0.5-1% of overall CPU usage on the machine, which was considered significant.
@kouvel kouvel added this to the 10.0.0 milestone Feb 21, 2025
@kouvel kouvel self-assigned this Feb 21, 2025
@Copilot Copilot bot review requested due to automatic review settings February 21, 2025 17:32

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/libraries/System.Private.CoreLib/src/System/Threading/PortableThreadPool.GateThread.cs:34

  • It looks like a new configuration variable has been introduced to control CPU utilization refresh behavior. Please ensure that there are tests verifying that CPU utilization updates are correctly enabled and disabled based on different values of cpuUtilizationIntervalMs, including edge cases (such as 0 for disabled and positive values for active updating).
int cpuUtilizationIntervalMs = AppContextConfigHelper.GetInt32Config(...

src/libraries/System.Private.CoreLib/src/System/Threading/PortableThreadPool.GateThread.cs:124

  • Please verify via tests that the interval check and subsequent CPU utilization update behave as expected; this includes ensuring that the timing logic (using Environment.TickCount differences) is robust in scenarios where the interval value is changed.
if (cpuUtilizationIntervalMs > 0 && ... && (uint)(currentTimeMs - lastCpuUtilizationRefreshTimeMs) >= (uint)cpuUtilizationIntervalMs)
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@kouvel kouvel merged commit c4f89bd into dotnet:main Feb 25, 2025
137 of 140 checks passed
@kouvel kouvel deleted the ConfigCpuUtil branch February 25, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants