[wasm] build paltests #112404
Open
[wasm] build paltests #112404
+471
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable few parts, some might need closer look later.
And also skip creating pipe to communicate with it
…t it was so you can pull the test statuses out of a log file
To avoid error messages at the end of each run
Also write missing tests
Also fix disabled tests count
Add few more notes to failing memory related tests
Emscripten's mmap doesn't support that and because we don't have virtual memory in wasm, it doesn't make sense to call it there
Also re-enable debug test, which works and disable few MT tests
This was referenced Feb 14, 2025
Open
janvorli
reviewed
Feb 26, 2025
src/coreclr/tools/superpmi/superpmi-shim-collector/CMakeLists.txt
Outdated
Show resolved
Hide resolved
src/coreclr/tools/superpmi/superpmi-shim-counter/CMakeLists.txt
Outdated
Show resolved
Hide resolved
| @@ -119,6 +119,10 @@ if (CLR_CMAKE_TARGET_UNIX OR CLR_CMAKE_TARGET_BROWSER OR CLR_CMAKE_TARGET_WASI) | |||
| add_subdirectory(System.IO.Ports.Native) | |||
| endif () | |||
|
|
|||
| if (MONO_WASM_MT) | |||
There was a problem hiding this comment.
it is a new flag to indicate mono wasm multithreaded build. one of the changes broke the mono build, so this way we can fix that
jkotas
reviewed
Feb 27, 2025
jkotas
reviewed
Feb 28, 2025
| arch/${PAL_ARCH_SOURCES_DIR}/debugbreak.S | ||
| arch/${PAL_ARCH_SOURCES_DIR}/exceptionhelper.S | ||
| ) | ||
| if (NOT CLR_CMAKE_TARGET_BROWSER) |
There was a problem hiding this comment.
Suggested change
| if (NOT CLR_CMAKE_TARGET_BROWSER) | |
| if (NOT CLR_CMAKE_TARGET_ARCH_WASM) |
| ) | ||
| endif() | ||
|
|
||
| if (CLR_CMAKE_TARGET_BROWSER) |
There was a problem hiding this comment.
Suggested change
| if (CLR_CMAKE_TARGET_BROWSER) | |
| if (CLR_CMAKE_TARGET_ARCH_WASM) |
|
|
||
| if(NOT CLR_CMAKE_TARGET_APPLE) | ||
| if(NOT CLR_CMAKE_TARGET_APPLE AND NOT CLR_CMAKE_TARGET_BROWSER) |
There was a problem hiding this comment.
Suggested change
| if(NOT CLR_CMAKE_TARGET_APPLE AND NOT CLR_CMAKE_TARGET_BROWSER) | |
| if(NOT CLR_CMAKE_TARGET_APPLE AND NOT CLR_CMAKE_TARGET_ARCH_WASM) |
| list(APPEND PLATFORM_SOURCES | ||
| arch/${PAL_ARCH_SOURCES_DIR}/callsignalhandlerwrapper.S | ||
| arch/${PAL_ARCH_SOURCES_DIR}/signalhandlerhelper.cpp | ||
| ) | ||
| endif(NOT CLR_CMAKE_TARGET_APPLE) | ||
| endif(NOT CLR_CMAKE_TARGET_APPLE AND NOT CLR_CMAKE_TARGET_BROWSER) |
There was a problem hiding this comment.
Suggested change
| endif(NOT CLR_CMAKE_TARGET_APPLE AND NOT CLR_CMAKE_TARGET_BROWSER) | |
| endif(NOT CLR_CMAKE_TARGET_APPLE AND NOT CLR_CMAKE_TARGET_ARCH_WASM) |
| @@ -0,0 +1,69 @@ | |||
| #include "pal/dbgmsg.h" | |||
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.