Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HMFs from JIT helpers #111134

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Conversation

AaronRobinsonMSFT
Copy link
Member

Convert JIT_UserBreakpoint to C#.
Convert JIT_GetRuntimeType and JIT_GetRuntimeType_MaybeNull to C#.

Contributes to #95695

@AaronRobinsonMSFT
Copy link
Member Author

/cc @dotnet/dotnet-diag

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • src/coreclr/inc/jithelpers.h: Language not supported
  • src/coreclr/vm/corelib.h: Language not supported
  • src/coreclr/vm/jithelpers.cpp: Language not supported
  • src/coreclr/vm/metasig.h: Language not supported
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Jan 6, 2025

@EgorBot -windows_intel

using System;
using System.Runtime.CompilerServices;

using BenchmarkDotNet.Attributes;

public class Bench
{
    [MethodImpl(MethodImplOptions.NoInlining)]
    internal Type M<T>() => typeof(T);

    [Benchmark]
    public Type GenericTypeOf() => M<string>();
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 16 changed files in this pull request and generated no comments.

Files not reviewed (13)
  • src/coreclr/debug/ee/frameinfo.h: Language not supported
  • src/coreclr/inc/jithelpers.h: Language not supported
  • src/coreclr/inc/vptr_list.h: Language not supported
  • src/coreclr/vm/corelib.h: Language not supported
  • src/coreclr/vm/ecalllist.h: Language not supported
  • src/coreclr/vm/frames.cpp: Language not supported
  • src/coreclr/vm/frames.h: Language not supported
  • src/coreclr/vm/jithelpers.cpp: Language not supported
  • src/coreclr/vm/metasig.h: Language not supported
  • src/coreclr/vm/runtimehandles.cpp: Language not supported
  • src/coreclr/vm/runtimehandles.h: Language not supported
  • src/coreclr/vm/typedesc.cpp: Language not supported
  • src/coreclr/vm/typedesc.h: Language not supported
Comments suppressed due to low confidence (1)

src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs:54

  • Ensure that AuxiliaryData is defined and used correctly in the context of GetRuntimeTypeFromHandle.
return (h.IsTypeDesc ? h.AsTypeDesc()->ExposedClassObject : h.AsMethodTable()->AuxiliaryData->ExposedClassObject) ?? GetRuntimeTypeFromHandleSlow(handle);
@AaronRobinsonMSFT
Copy link
Member Author

@jkotas Got it back to parity - EgorBot/runtime-utils#225 (comment)

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jkotas jkotas merged commit 8170344 into dotnet:main Jan 8, 2025
88 of 90 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the hmf_jithelpers04 branch January 8, 2025 20:04
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants