-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HMFs from JIT helpers #111134
Remove HMFs from JIT helpers #111134
Conversation
/cc @dotnet/dotnet-diag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (4)
- src/coreclr/inc/jithelpers.h: Language not supported
- src/coreclr/vm/corelib.h: Language not supported
- src/coreclr/vm/jithelpers.cpp: Language not supported
- src/coreclr/vm/metasig.h: Language not supported
Tagging subscribers to this area: @mangod9 |
@EgorBot -windows_intel using System;
using System.Runtime.CompilerServices;
using BenchmarkDotNet.Attributes;
public class Bench
{
[MethodImpl(MethodImplOptions.NoInlining)]
internal Type M<T>() => typeof(T);
[Benchmark]
public Type GenericTypeOf() => M<string>();
} |
...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 16 changed files in this pull request and generated no comments.
Files not reviewed (13)
- src/coreclr/debug/ee/frameinfo.h: Language not supported
- src/coreclr/inc/jithelpers.h: Language not supported
- src/coreclr/inc/vptr_list.h: Language not supported
- src/coreclr/vm/corelib.h: Language not supported
- src/coreclr/vm/ecalllist.h: Language not supported
- src/coreclr/vm/frames.cpp: Language not supported
- src/coreclr/vm/frames.h: Language not supported
- src/coreclr/vm/jithelpers.cpp: Language not supported
- src/coreclr/vm/metasig.h: Language not supported
- src/coreclr/vm/runtimehandles.cpp: Language not supported
- src/coreclr/vm/runtimehandles.h: Language not supported
- src/coreclr/vm/typedesc.cpp: Language not supported
- src/coreclr/vm/typedesc.h: Language not supported
Comments suppressed due to low confidence (1)
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs:54
- Ensure that
AuxiliaryData
is defined and used correctly in the context ofGetRuntimeTypeFromHandle
.
return (h.IsTypeDesc ? h.AsTypeDesc()->ExposedClassObject : h.AsMethodTable()->AuxiliaryData->ExposedClassObject) ?? GetRuntimeTypeFromHandleSlow(handle);
@jkotas Got it back to parity - EgorBot/runtime-utils#225 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Convert
JIT_UserBreakpoint
to C#.Convert
JIT_GetRuntimeType
andJIT_GetRuntimeType_MaybeNull
to C#.Contributes to #95695