JIT: Delay creation of scratch block needed by backend #110396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frontend created a scratch BB required by the backend. Having a long term invariant like this seems unnecessary; instead create the scratch BB in lowering to shorten the time we have this invariant.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Dec 4, 2024
|
/azp run runtime-coreclr superpmi-replay |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Subsumed by #110404 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frontend created a scratch BB required by the backend. Having a long term invariant like this seems unnecessary; instead create the scratch BB in lowering to shorten the time we have this invariant.
Motivation: dotnet/runtimelab#2847 (comment)
I think it would be better to guarantee a scratch BB throughout the JIT pipeline (we have discussed this before), but I think that should come with debug checks and seemed like it might also come with diffs, so I didn't want to do it here.