-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] stop testing with nodejs #108582
[browser] stop testing with nodejs #108582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might be missing removal of this and places it's being called at:
private static void UpdateRuntimeconfigTemplateForNode(string projectDir)
Edit: it's not called from anywhere...
Is used for |
We're not testing libs with v8 anymore, so that would make it consistent. |
Yes, it can be done here or in a follow up. Are we going to explicitly remove parts of typescript related to node? |
Let's do it in follow up. @lewing please confirm we have quorum on removing console from
Let's do that in yet another separate PR and we will see how many things there are. I guess it's not that many and possibly we could leave it in place. |
I understand that we are using v8 to save resources during running tests, however I don't see much difference in the time used in
I am proposing:
|
/ba-g failures are DebuggerTests, not related |
To reduce WASM test matrix
WasmTestOnNodeJS
scenarioWasm.Build.Tests
testsI left in place
PlatformDetection.IsNotNodeJS