Move the NoGC helper classification to HelperCallProperties #105040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a TODO and centralizes the assumptions about helpers in one place.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
@dotnet/jit-contrib |
EgorBo
reviewed
Jul 17, 2024
|
|
||
| switch (helper) | ||
| { | ||
| // Arithmetic helpers that cannot throw | ||
| case CORINFO_HELP_LLSH: | ||
| case CORINFO_HELP_LRSH: | ||
| case CORINFO_HELP_LRSZ: | ||
| isNoGC = true; | ||
| FALLTHROUGH; | ||
| case CORINFO_HELP_LMUL: | ||
| case CORINFO_HELP_LNG2DBL: | ||
| case CORINFO_HELP_ULNG2DBL: |
There was a problem hiding this comment.
just randomly checked CORINFO_HELP_ULNG2DBL and it also looks nogc, but I presume your PR just cleans things up
There was a problem hiding this comment.
Right, this is intentionally meant to be no-diff. Additionally, these no-gc annotations are a bit scary to maintain: they must match between CoreCLR and NAOT, and only CoreCLR is tested with GCStress.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a TODO and centralizes the assumptions about helpers in one place.
(Also, makes things simpler downstream.)
No diffs.