Avoid SerialPort IOLoop when there's no event handlers #102829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-io-ports |
|
@krwq could you have a look at this? |
krwq
approved these changes
Nov 18, 2024
|
Thanks @MrJul and really sorry for the super late review |
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids starting the
SerialPortI/O loop uncondtionally on Unix.dotnet/corefx#40383 added support for the
PinChangedevent on the Unix version ofSerialStream.However, since
SerialPortwas always subscribing toSerialStream.PinChanged, this had the side effect of always starting theIOLoop, even when no events were actually subscribed on theSerialPort.This PR changes this behavior.
SerialStream.PinChangedis only subscribed to ifSerialPort.PinChangedhas handlers.This mimics the logic for the
DataReceivedevent.When no events are subscribed, opening a
SerialPortwithout reading or writing now doesn't use any CPU.First part of fixing #2379 (CPU usage still remains high when reading/writing).