Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satellite assembly support in NativeAOT #86651

Closed
Tracked by #80905
akoeplinger opened this issue May 23, 2023 · 2 comments · Fixed by #86689
Closed
Tracked by #80905

Satellite assembly support in NativeAOT #86651

akoeplinger opened this issue May 23, 2023 · 2 comments · Fixed by #86689

Comments

@akoeplinger
Copy link
Member

akoeplinger commented May 23, 2023

While working on NativeAOT for iOS support we noticed that satellite resource assemblies aren't loaded in NativeAOT.

This seems to be expected for now:

if (culture == "" || culture.Equals("neutral", StringComparison.OrdinalIgnoreCase))
{
// NativeAOT doesn't consume resource assemblies yet so skip them
list.Add(taskItem);

Filing this issue to track enabling satellite assembly support.

/cc @MichalStrehovsky @jkotas

@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 23, 2023
@ghost
Copy link

ghost commented May 23, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

While working on NativeAOT for iOS support we noticed that satellite resource assemblies aren't loaded in NativeAOT.

This seems to be expected for now:

if (culture == "" || culture.Equals("neutral", StringComparison.OrdinalIgnoreCase))
{
// NativeAOT doesn't consume resource assemblies yet so skip them
list.Add(taskItem);

Filing this issue to track enabling satellite assembly support.

/cc @MichalStrehovsky @jkotas

Author: akoeplinger
Assignees: -
Labels:

untriaged, area-NativeAOT-coreclr

Milestone: -

@rolfbjarne
Copy link
Member

I ran into this with the following code:

var manager = new ResourceManager ("monotouchtest.Welcome", typeof (ResourcesTest).Assembly);
Assert.AreEqual ("G'day!", manager.GetString ("String1", new CultureInfo ("en-AU")), "en-AU");

seems like this is something quite a few apps would need in order to be shippable.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 24, 2023
MichalStrehovsky added a commit that referenced this issue May 29, 2023
Fixes #86651.

This was implemented in .NET Native so we just need to resurface it from the compiler.

Note that this is not full support for satellite assemblies (in the assembly binder, etc.) that never existed and nobody ever asked for and I don't even know what it entails.
@ghost ghost removed in-pr There is an active PR which will close this issue when it is merged untriaged New issue has not been triaged by the area owner labels May 29, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants