Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertion failed 'op1 != nullptr' #60957

Closed
BruceForstall opened this issue Oct 28, 2021 · 1 comment · Fixed by #60958
Closed

Assertion failed 'op1 != nullptr' #60957

BruceForstall opened this issue Oct 28, 2021 · 1 comment · Fixed by #60958
Assignees
@BruceForstall
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
7.0.0

Comments

@BruceForstall
Copy link
Member 

Assert failure(PID 28488 [0x00006f48], Thread: 28464 [0x6f30]): Assertion failed 'op1 != nullptr' in 'mdarray.Program:test10(System.Int32[,])' during 'Importation' (IL size 119)

    File: C:\gh\runtime2\src\coreclr\jit\gentree.cpp Line: 5955
    Image: c:\gh\runtime2\artifacts\tests\coreclr\windows.x64.Debug\Tests\Core_Root\corerun.exe

#60816 turned three multi-dimensional System.Array helpers into JIT intrinsics. The implementation didn't handle the case where the array object this pointer was not a simple local variable, e.g., was the result of a function call.
@BruceForstall BruceForstall added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 28, 2021
@BruceForstall BruceForstall added this to the 7.0.0 milestone Oct 28, 2021
@BruceForstall BruceForstall self-assigned this Oct 28, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Oct 28, 2021
@ghost
Copy link

ghost commented Oct 28, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details 
Assert failure(PID 28488 [0x00006f48], Thread: 28464 [0x6f30]): Assertion failed 'op1 != nullptr' in 'mdarray.Program:test10(System.Int32[,])' during 'Importation' (IL size 119)

    File: C:\gh\runtime2\src\coreclr\jit\gentree.cpp Line: 5955
    Image: c:\gh\runtime2\artifacts\tests\coreclr\windows.x64.Debug\Tests\Core_Root\corerun.exe

#60816 turned three multi-dimensional System.Array helpers into JIT intrinsics. The implementation didn't handle the case where the array object this pointer was not a simple local variable, e.g., was the result of a function call.

Author: BruceForstall
Assignees: BruceForstall
Labels:

area-CodeGen-coreclr
Milestone: 7.0.0

@BruceForstall BruceForstall removed the untriaged New issue has not been triaged by the area owner label Oct 28, 2021
BruceForstall added a commit to BruceForstall/runtime that referenced this issue Oct 28, 2021
@BruceForstall
Fix MD array helper intrinsics for complex this pointers
11f12f5 
The implementation of the MD array helpers didn't consider the possibility
of the array object being something complex, like a function call return value.

Also, add a test case covering many cases of invoking the MD array helpers.

Fixes dotnet#60957
@BruceForstall BruceForstall mentioned this issue Oct 28, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 28, 2021
BruceForstall added a commit that referenced this issue Oct 28, 2021
@BruceForstall
Fix MD array helper intrinsics for complex this pointers (#60958)
f26197d 
The implementation of the MD array helpers didn't consider the possibility
of the array object being something complex, like a function call return value.

Also, add a test case covering many cases of invoking the MD array helpers.

Fixes #60957
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 28, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BruceForstall BruceForstall

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Fix MD array helper intrinsics for complex this pointers BruceForstall/runtime
1 participant
@BruceForstall