Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP/3: Unit test variable length encoding #51519

Closed
JamesNK opened this issue Apr 19, 2021 · 7 comments · Fixed by #60766
Closed

HTTP/3: Unit test variable length encoding #51519

JamesNK opened this issue Apr 19, 2021 · 7 comments · Fixed by #60766
Assignees
@pedrobsaila
Labels
area-System.Net.Http help wanted [up-for-grabs] Good issue for external contributors test-enhancement Improvements of test source code
Milestone
7.0.0

Comments

@JamesNK
Copy link
Member

JamesNK commented Apr 19, 2021

I discovered an issue in the shared variable-length encoding source code - #51486

This type doesn't have any unit tests. Some should be added to check there are no further problems.
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 19, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Apr 19, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

I discovered an issue in the shared variable-length encoding source code - #51486

This type doesn't have any unit tests. Some should be added to check there are no further problems.

Author: JamesNK
Assignees: -
Labels:

area-System.Net.Http, untriaged
Milestone: -

@JamesNK JamesNK mentioned this issue Apr 19, 2021
Merged
@ManickaP
Copy link
Member

Triage: we should have this covered by Unit Tests.

@ManickaP ManickaP added this to the 6.0.0 milestone Apr 22, 2021
@ManickaP ManickaP added test-enhancement Improvements of test source code and removed untriaged New issue has not been triaged by the area owner labels Apr 22, 2021
@karelz karelz modified the milestones: 6.0.0, Future Jun 22, 2021
@karelz karelz modified the milestones: Future, 7.0.0 Sep 21, 2021
@karelz karelz added the help wanted [up-for-grabs] Good issue for external contributors label Sep 21, 2021
@karelz
Copy link
Member

karelz commented Sep 21, 2021

Triage: This should be fairly straightforward, we can provide guidance if needed.

@pedrobsaila
Copy link
Contributor

Hi.
I would like to work on this issue

@karelz
Copy link
Member

karelz commented Oct 21, 2021

Great @pedrobsaila, let us know if you need any guidance / tips. Thanks!

@pedrobsaila pedrobsaila mentioned this issue Oct 22, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 22, 2021
@pedrobsaila
Copy link
Contributor

Hi I made a PR #60766

karelz pushed a commit that referenced this issue Nov 9, 2021
@pedrobsaila
Add unit test for variable length encoding HTTP/3 (#60766)
6d5f59b 
Fixes #51519
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Nov 9, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pedrobsaila pedrobsaila

Labels
area-System.Net.Http help wanted [up-for-grabs] Good issue for external contributors test-enhancement Improvements of test source code
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

add unit test for variable length encoding HTTP/3 pedrobsaila/runtime
4 participants
@JamesNK @karelz @ManickaP @pedrobsaila