Skip to content

Commit

Permalink
Set additional Encoding param to be nullable and refactor ValidateArg…
Browse files Browse the repository at this point in the history
…sAndOpenPath to not require Encoding param anymore like StreamWriter
  • Loading branch information
eriawan committed Dec 16, 2024
1 parent e58b5e5 commit bebfe95
Showing 1 changed file with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ public StreamReader(string path, Encoding? encoding, bool detectEncodingFromByte
}

public StreamReader(string path, Encoding? encoding, bool detectEncodingFromByteOrderMarks, int bufferSize)
: this(ValidateArgsAndOpenPath(path, encoding, bufferSize), encoding, detectEncodingFromByteOrderMarks, bufferSize, leaveOpen: false)
: this(ValidateArgsAndOpenPath(path, bufferSize), encoding, detectEncodingFromByteOrderMarks, bufferSize, leaveOpen: false)
{
}

Expand All @@ -224,10 +224,9 @@ private static FileStream ValidateArgsAndOpenPath(string path, FileStreamOptions
return new FileStream(path, options);
}

private static FileStream ValidateArgsAndOpenPath(string path, Encoding encoding, int bufferSize)
private static FileStream ValidateArgsAndOpenPath(string path, int bufferSize)
{
ArgumentException.ThrowIfNullOrEmpty(path);
ArgumentNullException.ThrowIfNull(encoding);
ArgumentOutOfRangeException.ThrowIfNegativeOrZero(bufferSize);

return new FileStream(path, FileMode.Open, FileAccess.Read, FileShare.Read, DefaultFileStreamBufferSize);
Expand Down

0 comments on commit bebfe95

Please sign in to comment.