Skip tests on Mono #75160
Merged
Skip tests on Mono #75160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functionality work both on little endian and bigendian architecture. Hence removing the assert statements. These can be verified by running CommandLine test suite.
Couple of visualBasic "EmitAndContinue" test cases fail with "Operation is not supported on this platform" error. Reason for these failure is that they are not supported on Mono. Ensured that these test cases are skipped when run on mono.
This reverts commit 534273d.
Couple of visualBasic "EmitAndContinue" test cases fail with "Operation is not supported on this platform" error. Reason for these failure is that they are not supported on Mono. Ensured that these test cases are skipped when run on mono.
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
dotnet-policy-service
bot
added
the
Community
jaredpar
requested changes
Sep 18, 2024
|
\cc @uweigand |
|
@jaredpar , The suggested changes have been incorporated and all tests are passing. |
jaredpar
requested changes
Oct 16, 2024
jaredpar
approved these changes
Oct 18, 2024
|
@dotnet/roslyn-compiler PTAL |
jjonescz
reviewed
Oct 18, 2024
| @@ -159,6 +159,7 @@ public static class ExecutionConditionUtil | |||
| public static bool IsWindowsDesktop => IsWindows && IsDesktop; | |||
| public static bool IsMonoDesktop => Type.GetType("Mono.Runtime") != null; | |||
| public static bool IsMono => MonoHelpers.IsRunningOnMono(); | |||
There was a problem hiding this comment.
Should we remove this property or change the logic to be IsMonoDesktop || IsMonoCore?
There was a problem hiding this comment.
(Separate PR or filing an issue here is fine as well.)
There was a problem hiding this comment.
I would prefer to remove as part of new PR.
Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
jjonescz
approved these changes
Oct 18, 2024
|
Thanks @giritrivedi |
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of visualBasic "EmitAndContinue" test cases fail with
"Operation is not supported on this platform" error.
Reason for this failure is that they are not supported on Mono.
Ensured that these test cases are skipped when run on mono.