Fix null coalescing operator emit with span conversion #75103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
jjonescz
force-pushed
the
FirstClassSpan-20-NullCoalesce
branch
from
bca6980 to
6029531
Compare
333fred
approved these changes
Sep 13, 2024
AlekseyTs
reviewed
Sep 17, 2024
| Debug.Assert(rewrittenLeft.Type is { }); | ||
| if (rewrittenLeft.Type.IsReferenceType && | ||
| BoundNode.GetConversion(leftConversion, leftPlaceholder) is { IsImplicit: true, IsUserDefined: false }) | ||
| BoundNode.GetConversion(leftConversion, leftPlaceholder) is { IsImplicit: true, IsUserDefined: false, IsSpan: false }) |
There was a problem hiding this comment.
Given the original comment above the if, it feels like the condition was a somewhat "roundabout" way of checking for an implicit reference conversion. With the additional condition we are still trying to check for what we are not looking for rather than checking for what we are looking for. Consider adjusting condition accordingly in order to make it more robust in the long run.
|
Done with review pass (commit 1) |
|
@333fred for another look as there was a small product code change, thanks |
333fred
approved these changes
Oct 1, 2024
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug discovered while running runtime tests (would be also discovered by building runtime with Debug version of roslyn but currently there are other unrelated asserts so I haven't tried that).
Test plan: #73445