-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge latest bits from 'main' branch into extensions branch #75090
Conversation
Workaround failure to declare GenerateManifests as a dependency of _CopyResolvedFilesToPublishPreserveNewest
* wip * wip * wip * fix * more fixes * testing more changes * trying another thing out * another try * last few fixes * Update azure-pipelines-integration-dartlab.yml Co-authored-by: Joey Robichaud <jorobich@microsoft.com> --------- Co-authored-by: Joey Robichaud <jorobich@microsoft.com>
Fix handling default copilot option values
…tion Lock translation of strings used to demonstrate identifier naming styles
We still had a reference to gitter, so I removed it.
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging. |
@jcouv, it looks fine to me at a glance. The integer arrays shouldn't change but I'd expect any changes to Roslyn classification type names to appear in the capabilities node for the LSIF generator. |
I'm on vacation. And @jasonmalinowski knows lsif better than I do :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes under Compilers LGTM, assuming CI is passing.
@jasonmalinowski Please take a look at a couple of IDE/LSIF tests updated. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDE changes look good.
Relates to test plan #66722
The last commit resolves conflicts.
@gundermanc @CyrusNajmabadi The two updated LSIF tests were pretty cryptic to me so I just updated the baseline but wasn't able to tell whether it's good.