Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate contentChanged parameter #74561

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Eliminate contentChanged parameter #74561

merged 1 commit into from
Jul 26, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Jul 25, 2024

Calculating the value is simple and more reliable. It will also allow us to call the APIs when we do not know what exact changes were made.

@tmat tmat requested a review from a team as a code owner July 25, 2024 20:46
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 25, 2024
@tmat
Copy link
Member Author

tmat commented Jul 25, 2024

@ToddGrun ptal

Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tmat tmat enabled auto-merge (squash) July 26, 2024 16:12
@tmat tmat merged commit 70998bc into dotnet:main Jul 26, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 26, 2024
@tmat tmat deleted the DocContentChanged branch July 26, 2024 21:55
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants