Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocumentState constructors refactoring #74559

Merged
merged 3 commits into from
Jul 26, 2024
Merged

DocumentState constructors refactoring #74559

merged 3 commits into from
Jul 26, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Jul 25, 2024 •
edited
Loading

Make TextDocumentState abstract type with a single constructor. This avoids duplicating constructor code in derived types.
Clean up properties, add TextDocumentState.WithAttributes that updates attributes of any TextDocumentState subtype.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 25, 2024
@tmat tmat marked this pull request as ready for review July 25, 2024 23:15
@tmat tmat requested a review from a team as a code owner July 25, 2024 23:15
@tmat
Copy link
Member Author

tmat commented Jul 25, 2024

@ToddGrun

@build-analysis build-analysis bot mentioned this pull request Jul 26, 2024
Open
3 tasks
@ToddGrun
Copy link
Contributor

Looks good!

In reply to: 2251553521

ToddGrun
ToddGrun approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tmat tmat enabled auto-merge (squash) July 26, 2024 16:12
@tmat tmat merged commit 880b946 into dotnet:main Jul 26, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 26, 2024
@tmat tmat deleted the DocCtors branch July 26, 2024 21:55
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
This was referenced Jul 31, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.12 P1
Development

Successfully merging this pull request may close these issues.
3 participants
@tmat @ToddGrun @RikkiGibson