Improve location that lambda errors are reported at. #69334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
CyrusNajmabadi
commented
Aug 2, 2023
CyrusNajmabadi
changed the title
|
@dotnet/roslyn-compiler this is ready for review. |
jcouv
reviewed
Aug 4, 2023
jcouv
reviewed
Aug 4, 2023
| IAnonymousFunctionOperation (Symbol: lambda expression) (OperationKind.AnonymousFunction, Type: null, IsInvalid) (Syntax: '(int i) => { }') | ||
| IBlockOperation (0 statements) (OperationKind.Block, Type: null, IsInvalid) (Syntax: '{ }') | ||
| IBlockOperation (0 statements) (OperationKind.Block, Type: null) (Syntax: '{ }') |
There was a problem hiding this comment.
I didn't follow, what caused the IOperation changes?
There was a problem hiding this comment.
Iop adds the isinvalid bit if the node overlaps a semantic diagnostic. Because the diagnostic got smaller, less nodes are marked as invalid.
jcouv
reviewed
Aug 4, 2023
jcouv
reviewed
Aug 4, 2023
CyrusNajmabadi
commented
Aug 4, 2023
|
@dotnet/roslyn-compiler for a second pair of eyes. Thanks! |
cston
approved these changes
Aug 4, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69322
This changes the place we report lambda/anonymous-delegate errors to be on the
=>anddelegatetoken of each construct respectively, instead of reporting the error on the entire expression.Lambdas are effectively unbounded in size, and reporting such a large error is both poor for the user experience (as it can squiggle a huge range of the buffer), it also often masks more important issues for the user to be aware of (like the actual error in the parameters or body that is causing the high level lambda problem).