Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash of type snippets after accessibility modifier #67055

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Fix crash of type snippets after accessibility modifier #67055

merged 1 commit into from
Mar 3, 2023

Conversation

DoctorKrolic
Copy link
Contributor

Same as #67054, but for type snippets

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner February 25, 2023 10:51
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Feb 25, 2023
@build-analysis build-analysis bot mentioned this pull request Feb 25, 2023
Open
5 tasks
@DoctorKrolic
Copy link
Contributor Author

@akhera99 Can you please take a look at this PR as well, it is very similar to the previous one you've already seen today, thanks!

@DoctorKrolic
Copy link
Contributor Author

Can someone restart CI here please? roslyn-integration-CI is stuck for more than a day, other failures are unrelated to changes in the PR

@akhera99 akhera99 merged commit eb719b7 into dotnet:main Mar 3, 2023
@ghost ghost added this to the Next milestone Mar 3, 2023
@akhera99
Copy link
Member

akhera99 commented Mar 3, 2023

Thanks for your contribution @DoctorKrolic!

@DoctorKrolic DoctorKrolic deleted the fix-type-snippets-after-accessibility-modifier branch March 3, 2023 19:52
@allisonchou allisonchou mentioned this pull request Mar 9, 2023
Closed
@allisonchou allisonchou modified the milestones: Next, 17.6 P3 Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhera99 akhera99 akhera99 approved these changes

Assignees
No one assigned
Labels
Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
17.6 P3
Development

Successfully merging this pull request may close these issues.
3 participants
@DoctorKrolic @akhera99 @allisonchou