Merge "generic attributes" to main #55577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refresh generic-attributes branch with latest bits from master
Co-authored-by: Julien Couvreur <julien.couvreur@gmail.com> Co-authored-by: Rikki Gibson <rigibson@microsoft.com>
…n into merges/main-to-features/generic-attributes
…-attributes Merges/main to features/generic attributes
…eatures/generic-attributes
…-attributes Merges/main to features/generic attributes
…eatures/generic-attributes
…-attributes Merges/main to features/generic attributes
…ures/generic-attributes
jaredpar
approved these changes
Aug 12, 2021
|
I've been advised to ignore the lsp-CI failure. |
ghost
added this to the
|
We did it @AviAvni 😄. This will be available in the "preview" LangVersion in dev17-preview4 and hopefully will release "stable" in .NET 7 / C# 11. Thanks for your help with this feature. |
5 tasks
|
@RikkiGibson Thank you very much |
The good news is, this is merged! |
|
🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #36285
We're shipping this feature in .NET 6 under the "preview" LangVersion.
We don't have an EnC test here but honestly I would like if I could wait for #54891 to be merged before writing one :). Will do this before "promoting" this feature out of preview. When I tried to verify manually I got a rude edit message. I think I was on a pretty recent .NET 6, but not certain now, so am also curious how I can determine which runtimes support editing custom attributes during EnC.