Move more rude edit analysis to semantics #54576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidwengier FYI |
davidwengier
reviewed
Jul 4, 2021
src/EditorFeatures/CSharpTest/EditAndContinue/TopLevelEditingTests.cs
Outdated
Show resolved
Hide resolved
Nit: Duplicated line Refers to: src/EditorFeatures/CSharpTest/EditAndContinue/TopLevelEditingTests.cs:1 in b253f78. [](commit_id = b253f78de8b678a33e0b670164dae0bcadd4fe12, deletion_comment = False) |
davidwengier
reviewed
Jul 4, 2021
src/EditorFeatures/CSharpTest/EditAndContinue/TopLevelEditingTests.cs
Outdated
Show resolved
Hide resolved
davidwengier
reviewed
Jul 4, 2021
src/EditorFeatures/CSharpTest/EditAndContinue/TopLevelEditingTests.cs
Outdated
Show resolved
Hide resolved
davidwengier
reviewed
Jul 5, 2021
src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs
Show resolved
Hide resolved
davidwengier
approved these changes
Jul 7, 2021
src/EditorFeatures/VisualBasicTest/EditAndContinue/TopLevelEditingTests.vb
Show resolved
Hide resolved
davidwengier
approved these changes
Jul 8, 2021
tmat
force-pushed
the
MoreEncSemanticAnalysis
branch
from
6a0e56b to
42957a4
Compare
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rude edits: renames, parameters, type parameters, enums, delegates